This is a static archive of the previous Open Grid Forum Redmine content management system saved from host redmine.ogf.org file /boards/15/topics/107?r=250 at Thu, 03 Nov 2022 15:31:02 GMT Minor editorial - Public Comments Archive - Open Grid Forum

Minor editorial

Added by Steve Hanson about 9 years ago

Section 7.1.2. HTML spec shows that a couple of words have the wrong font.

Front page: 'obsolets'

Section 30. [OBSOLETE_DFDL]. Typos 'Steven' and '172'

Authors. Add Jonathan Cranford to list of contributors.

Authors. Alan Powell listed here as author but not on front page header.


Replies (25)

RE: Minor editorial - Added by Steve Hanson about 9 years ago

Also, in the Word document's Navigation pane, section 12.3.7.3 has text '\* MERGEFORMAT' preceding the section title ??

RE: Minor editorial - Added by Steve Hanson about 9 years ago

Section 15. The property names in the table are 9 point, they should be 10 point.

RE: Minor editorial - Added by Jonathan Cranford almost 9 years ago

Page 18, 4th full paragraph: "The validity of an element is recorded in the DFDL Infoset..." There's an extra space between "element" and "is".

RE: Minor editorial - Added by Jonathan Cranford almost 9 years ago

Section 22.2.1 dfdl:element (simple) and dfdl:simpleType - dfdl:textBiDiOrientation has improper capitalization in several places

Resolved: Minor editorial - Added by Steve Hanson almost 9 years ago

All trivial and uncontroversial updates, so can mark this as Resolved.
Feel free to add any more such comments.

Resolved: Minor editorial - Added by Steve Hanson almost 9 years ago

Section 12.3.5. First sentence after the property table should use dfdl: prefix with lengthKind.

Section 9.3.3. Table does not follow usual formatting rules, and does not have a table number.

RE: Minor editorial - Added by Jonathan Cranford almost 9 years ago

Section 3 - grammar error in the "Statically" entry:

Statically - A DFDL Implementation can analyze a DFDL schema and determine the presence of many kinds of errors this is called static analysis, compilation of the schema, or determining the presence of the error statically.

Resolved - RE: Minor editorial - Added by Michael Beckerle almost 9 years ago

All these minor editorials will be fixed.

Resolved: Minor editorial - Added by Steve Hanson almost 9 years ago

fn:round says "Rounds to the nearest number with no fractional part", it should clarify the behaviour when the value is x.5 (which is to round towards positive infinity).

Resolved: Minor editorial - Added by Steve Hanson almost 9 years ago

textStandardExponentRep.
- "Defines the actual character(s) thr that will appear ..." (thr)
- "... and dfdl:textStandardBase is 10. .Empty string is ..." (.Empty)

Resolved: Minor editorial - Added by Steve Hanson almost 9 years ago

5 mis-spellings of 'occurrence' as 'occurence'.

Resolved: Minor editorial - Added by Steve Hanson almost 9 years ago

In Section 23.5.3, the description for functions dfdl:timeZoneFromXXX say "Returns the timezone component of $arg if any as an xs:string". The "if any" could be taken as applying to "$arg" but it applies to "the timezone component". So better wording is "Returns the timezone component if any of $arg as an xs:string".

RE: Minor editorial - Added by Kevin Safford almost 9 years ago

Perhaps better as "Returns the timezone component, if any, of $arg as an xs:string."

RE: Minor editorial - Added by Kevin Safford almost 9 years ago

13.7 has this text:

"binaryPackedSignCodes | List of Character"

s/Character/Characters/

Resolved: Minor editorial - Added by Steve Hanson almost 9 years ago

Section 7.3, first assert example says:

<dfdl:assert message="Value is not zero." test="{ ../x ne 0}" />

It should be:

<dfdl:assert message="Value is not zero." test="{ ../x eq 0}" />

The message is issued when the assert fails, not when it passes!

Resolved: Minor editorial - Added by Steve Hanson almost 9 years ago

Section 7.3, second assert example, typo '..y' should be '../y'

RE: Minor editorial - Added by Mark Frost over 8 years ago

The type "List of DFDL String Literals" is referred to as "space separated" and "whitespace separated" interchangeably in various places in GFD-P-R.207.
I believe this needs to be "whitespace separated" everywhere, so behaviour would match schema's xs:list (xs:list types always have whitespace collapsing, so are effectively separated by any whitespace chars)

References are often in the definition of other dfdl properties eg:
  • section 6.3 "The property value is a space-separated list of the specified type"
  • section 12.2 "initiator : List of DFDL String Literals or DFDL Expression. Specifies a whitespace separated list of alternative literal strings "
  • section 13.2.1 "extraEscapedCharacters : List of DFDL String Literals. A space separated list of single characters "

Resolved: Minor editorial - Added by Jonathan Cranford over 8 years ago

Section 13.6.1.1 under Figure 4. The definition of the term "maximum integer digits" has two periods in the sentence, one before the footnote and one after.

RE: Minor editorial - Added by Jonathan Cranford over 8 years ago

Sections 5.2.6 and 5.2.7 (on default and fixed properties, respectively) both refer to section 13.15 "Nil Value Processing".

However, looking at the changes and comments from version 1.0.3 of the spec, it looks like the relevant verbiage was moved from section 13.15 to section 9.4 "Element Defaults". Section 13.15 no longer explains the default and fixed properties, but section 9.4 does.

I recommend updating the reference in sections 5.2.6 and 5.2.7 to section 9.4 "Element Defaults".

Leaving the subject line without the Resolved tag until Steve or Mike can confirm.

Resolved: Minor editorial - Added by Steve Hanson over 8 years ago

Section 13.2.1, description of escapeKind:

"On parsing the dfdl:escapeCharacter and dfdl:escapeEscapeCharacter are removed from the data, unless the dfdl:escapeCharacter is preceded by the dfdl:escapeEscapeCharacter, or the dfdl:escapeEscapeCharacter does not proceed the dfdl:escapeCharacter."

'proceed' should be 'precede'

Resolved: Minor editorial - Added by Steve Hanson over 8 years ago

Editorial - no update to experience documents needed.

Resolved: Minor editorial - Added by Steve Hanson over 8 years ago

Section 12.3.4, property description for prefixLengthType. The paragraph giving the restrictions is better off as a bulleted list:

It is a schema definition error if the xs:simpleType specifies any of:
- dfdl:lengthKind 'delimited' or 'endOfParent' or 'pattern'
- dfdl:lengthKind 'explicit' where length is an expression
- dfdl:outputValueCalc,
- dfdl:initiator or dfdl:terminator other than empty string
- dfdl:alignment other than '1'
- dfdl:leadingSkip or dfdl:trailingSkip other than '0'

(Point raised by IBM translator)

RE: Minor editorial - Added by Kevin Safford over 8 years ago

From G11n:

13.6
s/syntaxconstructs/syntax constructs/g
13.13
s/See Properties specific to numbers with binary representation section : 13.7 Properties Specific to Numbers with Binary Representation./See 13.7 Properties Specific to Numbers with Binary Representation./

RE: Minor editorial - Added by Michael Beckerle over 8 years ago

CHECKPOINT

Edited in all prior (2014-03-25) into draft spec gwdrp-dfdl-1.0.4-r04.docx.

DONE - RE: Minor editorial - Added by Michael Beckerle over 8 years ago

Please do not add additional minor editorials to this item. Create a new item.

(1-25/25)

This is a static archive of the previous Open Grid Forum Redmine content management system saved from host redmine.ogf.org file /boards/15/topics/107?r=250 at Thu, 03 Nov 2022 15:31:02 GMT