bug #59
typos and clearification
| Status: | closed | Start date: | 01/25/2013 | |
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: | - | % Done: | 0% |
|
| Category: | - | |||
| Target version: | - |
Description
Just in order to have them available in case of an errata of the C language binding:
- drmaa2_dict_free (C Spec Page 6) drmaa2_dict_free does not mention that dict is set to NULL after successful deletion
- Typos: drmaa2_list_get(const list, long pos) --> should be "const long pos"
same: drmaa2_list_del(dmraa2_list, long pos) -> const long pos
same: dmraa2_jsession_run_bulk_jobs () -> all indexes should be "const"
History
Updated by Peter Tröger about 9 years ago
- Status changed from submitted to accepted
All reviewed and agreed. Thanks.
Updated by Stefan Klauck about 9 years ago
It should be mentioned that all drmaa2_*_free functions set the pointers to NULL.
Concerning const for parameters of type long:
Both declarations are identical (i.e. nothing changes for drmaa users), but
using const improves documentation and
might prevent drmaa implementers from doing stupid mistakes.
Updated by Peter Tröger about 8 years ago
- Status changed from accepted to final review
Agreed by OGF-42 meeting.
Updated by Peter Tröger over 7 years ago
- Status changed from final review to closed
"const" issue fixed with the July 2015 errata.
The additional "NULL" comment was not added, since the pointer is call-by-ref, so there is no chance for the DRMAA implementation to change it.
(Other formats not available in this archive.