This is a static archive of the previous Open Grid Forum Redmine content management system saved from host redmine.ogf.org file /boards/21/topics/419 at Thu, 03 Nov 2022 15:39:00 GMT Comments on document - Public Comments Archive - Open Grid Forum

Comments on document

Added by Jens Jensen about 8 years ago

Mostly read up to section 3. Any questions about the comments, please feel free to contact me: jens.jensen <at> stfc.ac.uk

p.4

"A bit can always be unambiguously identified as the $2^n$-bit"
- did you mean "[..] for some $n$", or did you mean "The $n$th bit
[..]"

Your bits now number 1..8 instead of 0..7

A picture might help, er, picture the adjacency: showing the bits in
the byte followed by the bits in the next byte. In fact the stuff in
section 2.2 is good, so I would insert a reference here saying "see
section 2.2 for the illustration" or something.

Nitpick: is it mandated how the alignment (up to a byte) is to be
filled? Should they always be zero bits?

Section 2.1

Nitpick: there is only one combination left, bigEndian with
leastSignificantBitFirst.

2.2

I like the coloured XML - nice.

2.5.

The example makes it clear enough but one can nitpick the text:

Technically the AlignmentFill doesn't occupy the most (resp least)
significant bits, since there might be a bit field in the most (resp
least) significant part - as indeed there is in your example.

"so the first AlignmentFill" - there could be more than one
AlignmentFill in a single byte!

comma after "dfdl:binaryNumberRep='binary'"

3.1, 3.2.

Some "Error! Reference source not found."


Replies (2)

Issue 236 - RE: Comments on document - Added by Michael Beckerle about 8 years ago

Thank you this was obviously a thorough reading of the document.
We will incorporate the things you mention above.

Issue to track fixing this http://redmine.ogf.org/issues/236

Closed - RE: Comments on document - Added by Michael Beckerle over 7 years ago

These comments have been incorporated, and the latest version is now up on the DFDL Workgroup Documents/Current folder.

(1-2/2)

This is a static archive of the previous Open Grid Forum Redmine content management system saved from host redmine.ogf.org file /boards/21/topics/419 at Thu, 03 Nov 2022 15:39:00 GMT